mirror/json-c
1
0
Fork 0
mirror of https://github.com/json-c/json-c.git synced 2026-09-07 16:46:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix object key leak on insertion failure

Browse Source
This commit is contained in:
Junki Lee
2026-08-21 13:18:26 +09:00
parent d17ad9d186
commit 2094974201
6 changed files with 76 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
json_object.c
+14 -4
View File
@@ -753,11 +753,21 @@ int json_object_object_add_ex(struct json_object *jso, const char *const key,
if (!existing_entry)
{
const void *const k =
(opts & JSON_C_OBJECT_ADD_CONSTANT_KEY) ? (const void *)key : strdup(key);
if (k == NULL)
char *key_copy = NULL;
const void *k = key;
if (!(opts & JSON_C_OBJECT_ADD_CONSTANT_KEY))
{
key_copy = strdup(key);
if (key_copy == NULL)
return -1;
k = key_copy;
}
if (lh_table_insert_w_hash(JC_OBJECT(jso)->c_object, k, val, hash, opts) < 0)
{
free(key_copy);
return -1;
return lh_table_insert_w_hash(JC_OBJECT(jso)->c_object, k, val, hash, opts);
}
return 0;
}
existing_value = (json_object *)lh_entry_v(existing_entry);
if (existing_value)