mirror/libbpf
1
0
Fork 0
mirror of https://github.com/netdata/libbpf.git synced 2026-04-01 06:09:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

libbpf: Remove several dead assignments

Browse Source 
Clang Static Analyzer (scan-build) reports several dead assignments in
libbpf where the assigned value is unconditionally overridden by another
value before it is read. Remove these assignments.

Signed-off-by: Viktor Malik <vmalik@redhat.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/5503d18966583e55158471ebbb2f67374b11bf5e.1677658777.git.vmalik@redhat.com
Signed-off-by: Daniel Müller <deso@posteo.net>
This commit is contained in:
Viktor Malik
2023-03-01 09:53:54 +01:00
committed by Andrii Nakryiko
parent 4c75268933
commit 3706449b1b
3 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/btf.c
View File

@@ -1000,8 +1000,6 @@ static struct btf *btf_parse_elf(const char *path, struct btf *base_btf,
} }
} }
err = 0;
if (!btf_data) { if (!btf_data) {
pr_warn("failed to find '%s' ELF section in %s\n", BTF_ELF_SEC, path); pr_warn("failed to find '%s' ELF section in %s\n", BTF_ELF_SEC, path);
err = -ENODATA; err = -ENODATA;

1
src/libbpf.c
View File

@@ -798,7 +798,6 @@ bpf_object__add_programs(struct bpf_object *obj, Elf_Data *sec_data,
progs = obj->programs; progs = obj->programs;
nr_progs = obj->nr_programs; nr_progs = obj->nr_programs;
nr_syms = symbols->d_size / sizeof(Elf64_Sym); nr_syms = symbols->d_size / sizeof(Elf64_Sym);
sec_off = 0;
for (i = 0; i < nr_syms; i++) { for (i = 0; i < nr_syms; i++) {
sym = elf_sym_by_idx(obj, i); sym = elf_sym_by_idx(obj, i);

3
src/relo_core.c
View File

@@ -1551,9 +1551,6 @@ int __bpf_core_types_match(const struct btf *local_btf, __u32 local_id, const st
if (level <= 0) if (level <= 0)
return -EINVAL; return -EINVAL;
local_t = btf_type_by_id(local_btf, local_id);
targ_t = btf_type_by_id(targ_btf, targ_id);
recur: recur:
depth--; depth--;
if (depth < 0) if (depth < 0)