mirror/libbpf
1
0
Fork 0
mirror of https://github.com/netdata/libbpf.git synced 2026-04-07 17:19:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

libbpf: Simplify the find_elf_sec_sz() function

Browse Source 
The check in the last return statement is unnecessary, we can just return
the ret variable.

But we can simplify the function further by returning 0 immediately if we
find the section size and -ENOENT otherwise.

Thus we can also remove the ret variable.

Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20220223085244.3058118-1-ytcoode@gmail.com
This commit is contained in:
Yuntao Wang
2022-02-23 16:52:44 +08:00
committed by Andrii Nakryiko
parent c85a8bbe9c
commit 426672106e
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libbpf.c
View File

@@ -1374,22 +1374,20 @@ static bool bpf_map_type__is_map_in_map(enum bpf_map_type type)
static int find_elf_sec_sz(const struct bpf_object *obj, const char *name, __u32 *size) static int find_elf_sec_sz(const struct bpf_object *obj, const char *name, __u32 *size)
{ {
int ret = -ENOENT;
Elf_Data *data; Elf_Data *data;
Elf_Scn *scn; Elf_Scn *scn;
*size = 0;
if (!name) if (!name)
return -EINVAL; return -EINVAL;
scn = elf_sec_by_name(obj, name); scn = elf_sec_by_name(obj, name);
data = elf_sec_data(obj, scn); data = elf_sec_data(obj, scn);
if (data) { if (data) {
ret = 0; /* found it */
*size = data->d_size; *size = data->d_size;
return 0; /* found it */
} }
return *size ? 0 : ret; return -ENOENT;
} }
static int find_elf_var_offset(const struct bpf_object *obj, const char *name, __u32 *off) static int find_elf_var_offset(const struct bpf_object *obj, const char *name, __u32 *off)