mirror/libbpf
1
0
Fork 0
mirror of https://github.com/netdata/libbpf.git synced 2026-04-07 17:19:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

bpf: Disallow bpf programs call prog_run command.

Browse Source 
The verifier cannot perform sufficient validation of bpf_attr->test.ctx_in
pointer, therefore bpf programs should not be allowed to call BPF_PROG_RUN
command from within the program.
To fix this issue split bpf_sys_bpf() bpf helper into normal kern_sys_bpf()
kernel function that can only be used by the kernel light skeleton directly.

Reported-by: YiFei Zhu <zhuyifei@google.com>
Fixes: b1d18a7574d0 ("bpf: Extend sys_bpf commands for bpf_syscall programs.")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
Alexei Starovoitov
2022-08-08 20:58:09 -07:00
committed by Andrii Nakryiko
parent 45dca19bd2
commit 6fdbfb00f1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/skel_internal.h
View File

@@ -66,13 +66,13 @@ struct bpf_load_and_run_opts {
const char *errstr; const char *errstr;
}; };
long bpf_sys_bpf(__u32 cmd, void *attr, __u32 attr_size); long kern_sys_bpf(__u32 cmd, void *attr, __u32 attr_size);
static inline int skel_sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr, static inline int skel_sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr,
unsigned int size) unsigned int size)
{ {
#ifdef __KERNEL__ #ifdef __KERNEL__
return bpf_sys_bpf(cmd, attr, size); return kern_sys_bpf(cmd, attr, size);
#else #else
return syscall(__NR_bpf, cmd, attr, size); return syscall(__NR_bpf, cmd, attr, size);
#endif #endif