From 93f360cf4b4673c1db66c24966d86180a7c1a5bf Mon Sep 17 00:00:00 2001 From: Eduard Zingerman Date: Fri, 17 Nov 2023 03:07:43 +0200 Subject: [PATCH] ci: don't set /dev/kvm permissions when CI user is root s390 tests are executed on selfhosted runner using root user, avoid setting /dev/kvm permissions in such case. This should fix CI failures like [0]. (Still necessary for x86 tests executed on standard github runners). [0] https://github.com/libbpf/libbpf/actions/runs/6898545987/job/18768732980?pr=752 Fixes: 168630f852d0 ("ci: give /dev/kvm 0666 permissions inside CI runner") Signed-off-by: Eduard Zingerman --- .github/workflows/test.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d3cc3a4..3ce52a1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -37,11 +37,13 @@ jobs: shell: bash run: | if [ -e /dev/kvm ]; then - echo "/dev/kvm exists, updating permissions" - echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' \ - | sudo tee /etc/udev/rules.d/99-kvm4all.rules > /dev/null - sudo udevadm control --reload-rules - sudo udevadm trigger --name-match=kvm + echo "/dev/kvm exists" + if [ $(id -u) != 0 ]; then + echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' \ + | sudo tee /etc/udev/rules.d/99-kvm4all.rules > /dev/null + sudo udevadm control --reload-rules + sudo udevadm trigger --name-match=kvm + fi else echo "/dev/kvm does not exist" fi