mirror/libbpf
1
0
Fork 0
mirror of https://github.com/netdata/libbpf.git synced 2026-03-30 05:09:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

libbpf: Make btf__resolve_size logic always check size error condition

Browse Source 
Perform size check always in btf__resolve_size. Makes the logic a bit more
robust against corrupted BTF and silences LGTM/Coverity complaining about
always true (size < 0) check.

Fixes: 69eaab04c675 ("btf: extract BTF type size calculation")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20191107020855.3834758-5-andriin@fb.com
This commit is contained in:
Andrii Nakryiko
2019-11-06 18:08:54 -08:00
committed by Andrii Nakryiko
parent fb929625dc
commit bada95a5f3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/btf.c
View File

@@ -269,10 +269,9 @@ __s64 btf__resolve_size(const struct btf *btf, __u32 type_id)
t = btf__type_by_id(btf, type_id); t = btf__type_by_id(btf, type_id);
} }
done:
if (size < 0) if (size < 0)
return -EINVAL; return -EINVAL;
done:
if (nelems && size > UINT32_MAX / nelems) if (nelems && size > UINT32_MAX / nelems)
return -E2BIG; return -E2BIG;