ops/ssh-agent
1
0
Fork 0
mirror of https://github.com/webfactory/ssh-agent.git synced 2026-09-07 13:06:56 +08:00
Code Issues Packages Projects Releases Wiki Activity
86 Commits 6 Branches 17 Tags
25fcd78aa32202988cb0209b14c32ea6fa0288b9
Commit Graph
49 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthias Pigulla 25fcd78aa3 Update GHA actions to current versions (#251) 
Automated batch commit by webfactory tooling
 2026-06-18 11:29:51 +02:00
Matthias Pigulla dc588b651f Update version numbers in the README examples 2024-02-06 10:28:20 +01:00
Matthias Pigulla d4b9b8ff72 Stop adding GitHub SSH keys (#171) 
We need to fix the SSH keys shipped with this action:
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/

But, we have another issue
(https://github.com/webfactory/ssh-agent/pull/108) with regards to host
keys: On self-hosted runners which are not ephemeral the known_host file
fills up with repeated entries, because every action run adds a new line
with the same host keys.

Also, on those machines, the old key will still be in the `known_hosts`
file.

IMHO this action should not be repsonsible for shipping SSH host keys,
that's too much responsibility.

This section in the code is a leftover from early days when GitHub
provided runners did not include SSH keys at all. For a long time
already, GH takes care of placing their SSH keys in their runner images.

For self-hosted runners, those people setting up the runner should fetch
and verify SSH keys themselves and put it into the `known_hosts` file.

I know this is a breaking change and is going to annoy users. But on the
other hand, there is no better opportunity to drop this feature than
with an emergency-style key revocation as today.

Closes #106, closes #129, closes #169, closes #170, closes #172.
 2023-03-24 12:15:25 +01:00
Matthias Pigulla 4512be8010 Update to actions/checkout@v3 (#143) 2022-10-25 17:23:31 +02:00
Matthias Pigulla 836c84ec59 Prepare a v0.7.0 release 2022-10-19 13:52:25 +00:00
Matthias Pigulla 8a9e20a586 Fix path to git binary on Windows runners (#140) 
This PR fixes an apparently wrong path to the `git` binary that was added in #136. 

According to https://github.com/actions/checkout/discussions/928#discussioncomment-3861581, the path should not contain the `usr/` part, although for `ssh-add` and `ssh-agent`, it has to.
 2022-10-19 14:55:54 +02:00
Matthias Pigulla 0a7dc1c09f Avoid nonsensical log message (#139) 
This change avoids the

`Comment for (public) key '' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.`

log message that was caused by inappropriate parsing of `ssh-add -L` output and confused a lot of users already.
 2022-10-19 14:54:52 +02:00
Matthias Pigulla 2c78a1c5d1 Update the CHANGELOG 2022-10-19 11:28:57 +00:00
Matthias Pigulla 28cb4d8505 Prepare a 0.6.0 release 2022-10-19 08:17:39 +00:00
Matthias Pigulla fc49353b67 Bump example version numbers in the README file 2021-11-20 11:43:25 +00:00
Matthias Pigulla bc6614de94 Update recent changes in the CHANGELOG file 2021-11-20 11:43:02 +00:00
Matthias Pigulla a652a400f2 Merge pull request #95 from mjhipp/mh_public_key_comment 2021-09-01 21:28:09 +02:00
Matthias Pigulla 5f066a372e Prepare a 0.5.3 release 2021-06-11 15:18:45 +02:00
Matthias Pigulla 81d965f2bd Tix a fypo 2021-06-03 23:33:40 +02:00
Matthias Pigulla 515d164e78 Run cleanup (post) step also on failure (#79) 
According to https://github.com/actions/runner/issues/987, this should run the post step (cleanup.js) also when a workflow fails.

Probably most important on self-hosted runners that are not ephemeral, to terminate SSH agents from failed jobs as well.
 2021-06-02 22:15:05 +02:00
Matthias Pigullaandrr-james-hickman 8569bedfe0 Mention "-scmProvider system" for XCode builds/Swift Package Manager 
Co-authored-by: rr-james-hickman <james.hickman@rakuten.com>
 2021-05-27 20:11:56 +00:00
Matthias Pigullaandrr-james-hickman 98f76b1158 Give an example of how to add a key comment 
Co-authored-by: rr-james-hickman <james.hickman@rakuten.com>
 2021-05-27 20:05:28 +00:00
Matthias Pigulla cb8b21017a Update version numbers in README for the next bugfix release 2021-04-07 12:30:27 +02:00
Matthias PigullaandSean Killeen aed5400f20 Log when a key is _not_ used as a deploy key 
Resolves #69.

Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
 2021-03-17 18:50:49 +00:00
Matthias PigullaandSean Killeen 4681241867 Use case-insensitive regex matching when scanning key comments 
Resolves #68, closes #70, closes #71.

Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
 2021-03-17 18:27:52 +00:00
Matthias Pigulla 4b6f4eb000 Windows virtual environment: Use SSH binaries from the Git suite (#63) 
* Use SSH binaries from the Git suite

* Try to kill the ssh-agent upon action termination on Windows as well
 2021-03-10 08:19:17 +01:00
Matthias Pigulla 795485730f Prepare 0.5.1 release 2021-03-10 08:17:18 +01:00
Matthias Pigulla 598c7ea894 Handle ENOENT exceptions with a graceful message 2021-03-05 20:17:14 +00:00
Matthias Pigulla 6b2f2c5354 Prepare README for the upcoming 0.5.0 release 2021-02-19 14:41:23 +01:00
Matthias Pigulla 4d06ea6a33 Add support for GitHub Deployment Keys through key comments (#59) 
Fixes #30, closes #38.
 2021-02-19 14:37:34 +01:00
Matthias Pigulla 85353917a2 Tweak README formatting 2021-02-13 21:26:12 +01:00
Matthias Pigulla e5df661fc4 Update README to mention Windows and/or Docker support 2021-02-13 20:25:14 +00:00
Matthias Pigulla 23e7ede81c Bump copyright in README 2021-02-13 20:03:25 +00:00
Matthias Pigulla edc2fe4f2e Support container-based workflows and Windows (#17) 2021-02-13 21:02:34 +01:00
Matthias PigullaandShaun Cooley 79096d29b0 Document how to pass input arguments during local development 
Suggested by @shaunco in #38.

Co-authored-by: Shaun Cooley <scooley@mapped.com>
 2021-02-12 18:04:53 +00:00
Matthias PigullaandShaun Cooley 5fedeb584e Fix scripts/build.js to work on Windows 
Suggested by @shaunco in #38.

Co-authored-by: Shaun Cooley <scooley@mapped.com>
 2021-02-12 18:03:48 +00:00
Matthias PigullaandFabian Schmick 43c9b3548b Nutze Composer v1, vermeide ::set-env (Case 115156, Case 115161) 
Anpassungen ausgeführt mit automatischer Migration.

Co-authored-by: Fabian Schmick <fs@webfactory.de>
 2020-11-10 20:28:49 +01:00
Matthias Pigulla ee29fafb6a Update README for a 0.4.1 release 2020-10-07 21:08:38 +00:00
Matthias Pigulla 3dd57c80a6 Update dependencies (#43) 2020-10-07 23:06:49 +02:00
Matthias Pigulla 9e5c1c7a9b Point to blog post explaining how to use multiple GitHub deploy keys 2020-09-07 16:57:21 +02:00
Matthias Pigulla ef0ce0cab8 Ignore failures when trying to kill the ssh-agent (#33) 2020-06-24 08:31:28 +02:00
Matthias Pigulla a82ae3cd1a Merge pull request #24 from jieter/patch-1 
Add omitted 'key' word
 2020-05-15 08:24:01 +02:00
Matthias Pigulla 716fbacac2 Merge pull request #21 from PrecisionNutrition/typeoneerror-patch-1 2020-03-03 14:49:55 +01:00
Matthias Pigulla 4d1295c53b Merge pull request #19 from jmandel/patch-1 
Remove redundant .trim()
 2020-02-08 13:21:01 +01:00
Matthias Pigulla 9d13200510 Bump copyright year in README 2020-01-14 09:35:08 +00:00
Matthias Pigulla b6c65becb0 Prepare the v0.2.0 release 2020-01-14 09:32:40 +00:00
Matthias Pigulla c6eb7ee1d8 Exit with a helpful error message when the secret has not been configured 2020-01-14 09:29:16 +00:00
Matthias Pigulla 6cf6299d23 Support multiple SSH keys (#14) 
* Support concatenation of multiple private keys in the given secret

* Add a changelog
 2020-01-14 10:21:11 +01:00
Matthias Pigulla ea39f521c5 Write down what this Action cannot do 
A few notes on what has been raised as issues recently.
 2019-11-28 17:52:10 +01:00
Matthias Pigulla 1a9af8e8e0 Update README to show correct version number in example 
Supersedes #3; thank you @kod-kristoff!
 2019-09-24 22:08:56 +00:00
Matthias Pigulla e181806200 Use $HOME to support OS X as well (#2) 
This fixes #1. Windows is currently not supported.
 2019-09-15 09:32:43 +02:00
Matthias Pigulla e9cec5c598 Create LICENSE 2019-09-15 01:14:12 +02:00
Matthias Pigulla c03703d9a1 Replace invalid icon 2019-09-15 00:33:18 +02:00
Matthias Pigulla 64d68c7e61 Write GH action to set up ssh keys for private repos 2019-09-14 22:28:16 +00:00